Skip to content

fix: cypress command reverted PR#39141

Merged
sagar-qa007 merged 1 commit intoreleasefrom
fix/commandupdate
Feb 10, 2025
Merged

fix: cypress command reverted PR#39141
sagar-qa007 merged 1 commit intoreleasefrom
fix/commandupdate

Conversation

@sagar-qa007
Copy link
Contributor

@sagar-qa007 sagar-qa007 commented Feb 10, 2025 •
edited by github-actions bot
Loading

Description

Tip

Add a TL;DR when the description is longer than 500 words or extremely technical (helps the content, marketing, and DevRel team).

Please also include relevant motivation and context. List any dependencies that are required for this change. Add links to Notion, Figma or any other documents that might be relevant to the PR.

Fixes #Issue Number
or
Fixes Issue URL

Warning

If no issue exists, please create an issue first, and check with the maintainers if the issue is valid.

Automation

/ok-to-test tags="@tag.Sanity"

🔍 Cypress test results

Tip

🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/13232350022
Commit: 7787d67
Cypress dashboard.
Tags: @tag.Sanity
Spec:

Mon, 10 Feb 2025 03:35:03 UTC

Communication

Should the DevRel and Marketing teams inform users about this change?

  • Yes
  • No

Summary by CodeRabbit

  • Tests

    • Improved the automated end-to-end testing process to ensure more reliable and consistent evaluations.

  • Chores

    • Streamlined internal workflows by replacing an older testing method with a standardized approach, enhancing overall maintainability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2025 •
edited
Loading

Walkthrough

The pull request updates the CI workflow for Cypress tests by replacing a custom command with the standard GitHub Action (cypress-io/github-action@v6). The new approach directly configures parameters such as browser, config file, spec, and working directory, and sets the NODE_ENV environment variable. The former use of the custom command (npx cypress-repeat-pro) has been removed to simplify and streamline test execution.

Changes

File Path Change Summary
.github/workflows/ci-test-custom-script.yml Switched from a custom Cypress command (npx cypress-repeat-pro) to using cypress-io/github-action@v6 with explicit parameters and env settings.

Sequence Diagram(s)

sequenceDiagram
    participant GH as GitHub Actions
    participant CI as ci-test job
    participant CYP as Cypress Action (v6)
    participant RUN as Cypress Test Runner

    GH->>CI: Trigger CI Workflow
    CI->>CYP: Invoke Cypress Action with parameters
    CYP->>RUN: Run Cypress tests
    RUN-->>CYP: Return test results
    CYP-->>CI: Report test outcomes
    CI-->>GH: Finish job execution
Loading

Possibly related PRs

Suggested labels

Bug, CI, ok-to-test

Suggested reviewers

  • sharat87
  • NandanAnantharamu

Poem

In the realm of tests, a change takes flight,
Cypress now shines in a brand-new light.
Custom commands fade into the past,
With GitHub Action, resilience holds fast.
Code sings with joy and builds run bright! 😊

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29b571e and 7787d67.

📒 Files selected for processing (1)
  • .github/workflows/ci-test-custom-script.yml (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
  • GitHub Check: perform-test / client-build / client-build
  • GitHub Check: perform-test / server-build / server-unit-tests
  • GitHub Check: perform-test / rts-build / build
🔇 Additional comments (3)
.github/workflows/ci-test-custom-script.yml (3)

305-310: Standardizing Cypress Test Execution
Great move replacing the custom command with the official Cypress GitHub Action. This refactoring simplifies test execution and improves maintainability by leveraging the well-supported cypress-io/github-action@v6.

312-313: Verify Test User 2 Password Secret Assignment
It appears that "CYPRESS_TESTPASSWORD2" is set to "${{ secrets.CYPRESS_TESTPASSWORD1 }}" instead of what one might expect ("${{ secrets.CYPRESS_TESTPASSWORD2 }}"). Please verify if this is intentional or if it’s a misconfiguration that needs correcting.

374-381: Review 'with' Block Parameters for Cypress Action
The provided parameters (browser, install, config-file, spec, working-directory) look well organized. The inclusion of an "env" key with "NODE_ENV=development" is noteworthy—please ensure this is supported by the cypress-io/github-action@v6 documentation. If the intended effect is to set the environment for the Cypress run, you might consider moving "NODE_ENV" to the step’s outer "env:" block if issues arise.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sagar-qa007 sagar-qa007 added the ok-to-test Required label for CI label Feb 10, 2025
@github-actions github-actions bot added the Bug Something isn't working label Feb 10, 2025
@sagar-qa007 sagar-qa007 merged commit da69c3c into release Feb 10, 2025
49 checks passed
@sagar-qa007 sagar-qa007 deleted the fix/commandupdate branch February 10, 2025 03:38
@coderabbitai coderabbitai bot mentioned this pull request Feb 10, 2025
Merged
2 tasks
@coderabbitai coderabbitai bot mentioned this pull request Mar 31, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharat87 sharat87 Awaiting requested review from sharat87 sharat87 is a code owner

1 more reviewer

@NandanAnantharamu NandanAnantharamu NandanAnantharamu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Bug Something isn't working ok-to-test Required label for CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sagar-qa007 @NandanAnantharamu